London | 26-ITP-JAN | Abdul Moiz | Sprint 1 | Data Groups#947
Open
A-Moiz wants to merge 7 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-JAN | Abdul Moiz | Sprint 1 | Data Groups#947A-Moiz wants to merge 7 commits intoCodeYourFuture:mainfrom
A-Moiz wants to merge 7 commits intoCodeYourFuture:mainfrom
Conversation
A-Moiz
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
A-Moiz
changed the title
This comment has been minimized.
This comment has been minimized.
A-Moiz
changed the title
A-Moiz
added
the
Needs Review
cjyuan
reviewed
Feb 18, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code is very solid. I only have a few suggestions.
Comment on lines
20
to
22
| // Given an array with no duplicates | ||
| // When passed to the dedupe function | ||
| // Then it should return a copy of the original array |
Contributor
There was a problem hiding this comment.
Can you also implement a test that checks if the function returns a copy of the original array?
Author
There was a problem hiding this comment.
Hi, that is already one of the test cases. On line 31:
{ input: ["apple", "banana", 1, 10], expected: ["apple", "banana", 1, 10] },
If you meant something else can you explain again please? Thanks.
Contributor
There was a problem hiding this comment.
This check does not check whether "the function returns a copy of the original array". It only checks if the returned value and expected have the same elements.
expect(dedupe(input)).toEqual(expected));
cjyuan
added
Reviewed
A-Moiz
added
Needs Review
cjyuan
reviewed
Feb 21, 2026
Sprint-1/implement/sum.test.js
Outdated
Comment on lines
37
to
43
| test(`Should return the correct sum of values`, () => { | ||
| expect(sum(["apple", "banana", 1, 10])).toEqual(11); | ||
| expect(sum([1, -1, -100])).toEqual(-100); | ||
| expect(sum([-10, -20, -3, -4])).toEqual(-37); | ||
| expect(sum([1.5, 10.5, 0.5])).toBeCloseTo(12.5); | ||
| expect(sum(["apple", "banana", "cherry"])).toEqual(-Infinity); | ||
| }); |
Contributor
There was a problem hiding this comment.
The description, “Should return the correct sum of values,” is quite broad. If any of the checks fail, it doesn’t clearly indicate why the function failed, making it harder for the tester to understand the specific issue.
cjyuan
added
Reviewed
A-Moiz
added
Needs Review
Contributor
|
Changes look good. Well done! |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed the exercises in each directory on Sprint 1
Questions
N/A