London | 26-ITP-Jan | Abdul Moiz | Sprint 3 | ToDo List#952
Open
A-Moiz wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Abdul Moiz | Sprint 3 | ToDo List#952A-Moiz wants to merge 3 commits intoCodeYourFuture:mainfrom
A-Moiz wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
A-Moiz
added
the
Needs Review
JaypeeLan
added
Review in progress
JaypeeLan
reviewed
Feb 21, 2026
Sprint-3/todo-list/index.html
Outdated
| <button id="add-task-btn">Add</button> | ||
| </div> | ||
| <div class="todo-input"> | ||
| <input |
There was a problem hiding this comment.
This works fine, and I know you are doing some validation with JavaScript. But since this is a required field, you can do some validation with HTML only. Check on how to do simple validation on input fields using HTML.
JaypeeLan
reviewed
Feb 21, 2026
| const deadlineInput = document.getElementById("new-task-deadline"); | ||
| const task = taskInput.value.trim(); | ||
| const deadline = deadlineInput.value || null; | ||
| if (task) { |
There was a problem hiding this comment.
This works. To improve the user experience, please throw an error to the user if there is no valid input (task in this case).
JaypeeLan
added
Reviewed
A-Moiz
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Questions
N/A