London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 1 | Bug Report: Can't log in from profile page#136
Open
aydaeslami wants to merge 4 commits intoCodeYourFuture:mainfrom
Open
London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 1 | Bug Report: Can't log in from profile page#136aydaeslami wants to merge 4 commits intoCodeYourFuture:mainfrom
aydaeslami wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
aydaeslami
added
the
Needs Review
OracPrime
approved these changes
Feb 19, 2026
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
One comment to note, but otherwise good
|
|
||
| // Home view - logged in or not | ||
| function homeView() { | ||
|
|
There was a problem hiding this comment.
Spurious whitespace changes make reviewing harder than it should be. Don't worry about this one, but try to avoid them in future.
OracPrime
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Fix login bug by changing event from button click to form submit.