Skip to content

London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 1 | Hashtag link doesn't work correctly#137

Open
aydaeslami wants to merge 1 commit intoCodeYourFuture:mainfrom
aydaeslami:hashtag
Open

London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 1 | Hashtag link doesn't work correctly#137
aydaeslami wants to merge 1 commit intoCodeYourFuture:mainfrom
aydaeslami:hashtag

Conversation

@aydaeslami
Copy link

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Fixed hashtag parsing to ensure links stop at whitespace and correctly navigate to the corresponding hashtag page.

@aydaeslami aydaeslami added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 12, 2026
Copy link

@OracPrime OracPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little room for improved clarity

if (!text) return text;
return text.replace(
/\B#[^#]+/g,
/\B#[a-zA-Z0-9_]+/g,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work, but if you check the standard regular expression terms, can you see an easier way?

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Purple Forest Kanban Feb 19, 2026
@OracPrime OracPrime added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants

Comments