Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Bug Report: Can't log in from profile page#139
Open
RahwaZeslusHaile wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
Conversation
RahwaZeslusHaile
changed the title
RahwaZeslusHaile
added
the
Needs Review
OracPrime
reviewed
Feb 19, 2026
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
There seem to be a whole bunch of changes nothing to do with fixing this bug?
front-end/views/hashtag.mjs
Outdated
| document | ||
| .querySelector("[data-action='login']") | ||
| ?.addEventListener("click", handleLogin); | ||
| .querySelector("[data-form='login']") |
There was a problem hiding this comment.
This change appears to be fixing the bug. What are all the other changes doing?
OracPrime
added
Reviewed
RahwaZeslusHaile
force-pushed
the
profile-login
branch
from
dbdc133 to
d09fa82
Compare
Author
|
@OracPrime, I initially understood that the sprint required us to raise a pull request addressing all identified bugs, which is why I included changes to the other file as well. Thank you for the feedback. I have now cleaned up the PR and removed the unnecessary changes, so it only contains the essential fix for the login issue. The branch has been updated accordingly. |
RahwaZeslusHaile
added
the
Needs Review
OracPrime
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Bug Report: Can't log in from profile page
Learners, PR Template
Self checklist
Changelist
This PR corrected the login form handler attachment on profile and hashtag pages to prevent unhandled form submissions.
Previously, the views were listening for a click on a non-existent element.
Verified login form submits correctly on profile and hashtag pages
Please review my work — thank you!