Manchester | 26-ITP-Jan | Ahmed Elmahmoudi | Sprint 2 | Form-Controls by Alaterry8 · Pull Request #1177 · CodeYourFuture/Module-Onboarding

Alaterry8 · 2026-02-14T15:46:44Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Within a form, I added a name field with minimum 2 characters length requirement. I added an email field. I added a set of 3 colours to select from. I added 6 radio options for Size options.

netlify · 2026-02-14T15:46:49Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`3063de4`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6998c4fdf1b2ae00080bdf9c
😎 Deploy Preview	https://deploy-preview-1177--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Form-Controls/index.html

SlideGauge · 2026-02-15T17:48:01Z

Form-Controls/index.html

+
+        <br> <br>
+        <label for="colour"> T-shirt colour:</label>
+        <select id="colour" name="T-shirt colour"> 


Note, we must require the user to actively select colour. Therefore initial option should be empty and we must demand the choise.

I fixed this by adding an empty option value, and made it required to choose a colour. Thanks!

It could be weird to see an empty choice in a dropdown list:

Could you make it more explicit to the user that they should choose a colour?

Thanks for the feedback, I added an indication text.

Form-Controls/index.html

SlideGauge · 2026-02-15T17:56:02Z

Form-Controls/index.html

-          try writing out the requirements first as comments
-        this will also help you fill in your PR message later-->
+        <label for="name"> Name: </label>
+        <input type="text" id="name" name="Name" minlength="2" required>


The convention for naming elements (i.e' name) is lowercase

so the only thing that can be capitalised is what goes between the label tags?

They serve different purposes. The text in the label is what users see on their browser. The value of name is intended to be consumed by a server-side script.

Can you use an AI tool to find out why it is better to express value of names in lowercase?

Yes, I understand now. Thanks.

SlideGauge · 2026-02-15T17:56:28Z

Form-Controls/index.html

+
+        <br> <br>
+        <label for="colour"> T-shirt colour:</label>
+        <select id="colour" name="T-shirt colour"> 


the convention for name is to avoid usage spaces. Use underscore or dash instead

Noted! fixed it. Thanks for all the feedback ;D

Why use t-shirt_colour for one input and just size (without t-shirt) for the other input?

Either format is acceptable, but it is better to keep the format consistent.

The same also applies to the labels.

@cjyuan That makes sense, I made the appropriate changes. Thanks for the pointers!

I was referring to name="t-shirt_colour" on line 27 and name="size" on the radio buttons.

@cjyuan Yea I understand the issue now, I changed it so it's more consistent

Alaterry8 · 2026-02-18T15:38:36Z

Hi @cjyuan @SlideGauge can you kindly review my changes, Thanks!

cjyuan · 2026-02-18T17:09:56Z

@Alaterry8 You have done a good job in addressing all of the reviewer's comments. I just have some more suggestions.

Alaterry8 · 2026-02-19T11:36:38Z

@cjyuan @SlideGauge Thanks for all the feedback, I made the suggested changes.

cjyuan · 2026-02-19T13:39:37Z

Can you address this #1177 (comment)? Other changes look good.

Alaterry8 · 2026-02-20T20:20:09Z

@cjyuan I made the changes, thanks for the feedback!

cjyuan · 2026-02-20T20:20:50Z

Can you push your changes to GitHub?

Alaterry8 · 2026-02-20T20:22:42Z

@cjyuan I did

cjyuan · 2026-02-20T20:24:54Z

No new commits made on this branch since yesterday. Did you made your changes on a different branch?

If you have made commit on your computer, you need to pusn/sync them to GitHub.

Alaterry8 · 2026-02-20T20:33:27Z

@cjyuan it should be synced now

Alaterry8 · 2026-02-20T20:55:24Z

@cjyuan How do I know that it is synced, where do the changes show on github?

cjyuan · 2026-02-20T21:01:21Z

Changes look good.

Note: To check if your latest commits were sync, you can check the commits history made on the branch.

Alaterry8 added 8 commits February 14, 2026 15:21

Add name field and submit button to test validation

11a6944

Add email field

667fd99

Add T-shirt colour field

8caf0c5

Add Size options via radio buttons

1dd5b4c

Remove submit button

0f0e9d3

Attach labels to unputs

1774cf2

Add spacing between controls

cda92fc

Check requirements

20bf3d9

Alaterry8 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 14, 2026

SlideGauge reviewed Feb 15, 2026

View reviewed changes

SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 15, 2026

Alaterry8 added 4 commits February 16, 2026 19:50

Add empty value to colour set and make it required to choose

d37ee80

Add fieldset for size options and make it required to choose

59dd754

fix capitalisation and spacing issues

99585ec

Capitalise Doctype

64112a7

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 18, 2026

Alaterry8 added 2 commits February 19, 2026 11:29

disable selected placeholder option

0b2f5d1

Standardise label format for consistency

960475b

Alaterry8 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 19, 2026

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 19, 2026

Make label format consistent

3063de4

Alaterry8 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 20, 2026

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 20, 2026

Uh oh!

Comments

Conversation

Alaterry8 commented Feb 14, 2026

Uh oh!

netlify bot commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Alaterry8 commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjyuan commented Feb 18, 2026

Uh oh!

Alaterry8 commented Feb 19, 2026

Uh oh!

cjyuan commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alaterry8 commented Feb 20, 2026

Uh oh!

cjyuan commented Feb 20, 2026

Uh oh!

Alaterry8 commented Feb 20, 2026

Uh oh!

cjyuan commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alaterry8 commented Feb 20, 2026

Uh oh!

Alaterry8 commented Feb 20, 2026

Uh oh!

cjyuan commented Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Feb 14, 2026 •

edited

Loading

cjyuan Feb 18, 2026 •

edited

Loading

Alaterry8 commented Feb 18, 2026 •

edited

Loading

cjyuan commented Feb 19, 2026 •

edited

Loading

cjyuan commented Feb 20, 2026 •

edited

Loading