Skip to content

Comments

London | 26-ITP-January | Laura C | Sprint 3 | Implement and Rewrite Tests#1000

Open
lauracs24 wants to merge 6 commits intoCodeYourFuture:mainfrom
lauracs24:coursework/sprint-3-implement-and-rewrite
Open

London | 26-ITP-January | Laura C | Sprint 3 | Implement and Rewrite Tests#1000
lauracs24 wants to merge 6 commits intoCodeYourFuture:mainfrom
lauracs24:coursework/sprint-3-implement-and-rewrite

Conversation

@lauracs24
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Implemented getAngleType and wrote console.assert tests covering all angle types, boundary cases, and invalid values.
  • Implemented `isProperFraction with tests covering proper, improper, equal, zero, negative, and denominator zero cases.
  • Implemented getCardValue with validation and error throwing for invalid inputs.
  • Rewrote all tests in the rewrite-tests-with-jest directory using Jest (expect, toEqual, toThrowError`).
  • Verified all tests pass for Sprint-3

Questions

Is my test coverage sufficient for boundary and invalid cases, or are there additional edge cases you would recommend testing?

@lauracs24 lauracs24 added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Feb 20, 2026
@lauracs24 lauracs24 moved this to Awaiting Approval🚀 in Coursework Planner Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Structuring-And-Testing-Data The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant