Skip to content

Comments

London|26-ITP-January|Alexandru Pocovnicu|Sprint 3| Implement and rewrite#924

Closed
alexandru-pocovnicu wants to merge 18 commits intoCodeYourFuture:mainfrom
alexandru-pocovnicu:coursework/sprint-3-implement-and-rewrite
Closed

London|26-ITP-January|Alexandru Pocovnicu|Sprint 3| Implement and rewrite#924
alexandru-pocovnicu wants to merge 18 commits intoCodeYourFuture:mainfrom
alexandru-pocovnicu:coursework/sprint-3-implement-and-rewrite

Conversation

@alexandru-pocovnicu
Copy link

@alexandru-pocovnicu alexandru-pocovnicu commented Feb 1, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Done the exercises from sprint 3 implement and rewrite

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@alexandru-pocovnicu alexandru-pocovnicu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 1, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 1, 2026
@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@alexandru-pocovnicu alexandru-pocovnicu changed the title London|26-ITP-January|Alexandru Pocovnicu|Coursework|sprint 3 implement and rewrite London|26-ITP-January|Alexandru Pocovnicu|Sprint 3| Implement and rewrite Feb 1, 2026
…oper fractions, negative fractions, and equal numerator and denominator scenarios
@alexandru-pocovnicu alexandru-pocovnicu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 1, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 17, 2026

Your PR branch is 7 commits behind CYF's main.

There will likely be merge conflict if you try to sync fork. It will probably be easier if you create a new branch and submit a new PR.

The spec has changed a bit. So please update your code accordingly.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 17, 2026
@cjyuan cjyuan added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Feb 17, 2026
@github-actions
Copy link

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/1-implement-and-rewrite-tests/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment
@github-actions
Copy link

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/1-implement-and-rewrite-tests/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@alexandru-pocovnicu alexandru-pocovnicu deleted the coursework/sprint-3-implement-and-rewrite branch February 17, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants