Skip to content

Comments

Sheffield | 26-Jan-ITP | Daniel Aderibigbe | Sprint 1 | coursework/sprint-1#941

Open
Dan2Clouted wants to merge 8 commits intoCodeYourFuture:mainfrom
Dan2Clouted:coursework/sprint-1
Open

Sheffield | 26-Jan-ITP | Daniel Aderibigbe | Sprint 1 | coursework/sprint-1#941
Dan2Clouted wants to merge 8 commits intoCodeYourFuture:mainfrom
Dan2Clouted:coursework/sprint-1

Conversation

@Dan2Clouted
Copy link

@Dan2Clouted Dan2Clouted commented Feb 7, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I created a new branch "coursework/sprint-1" and i have completed all the work in the sprint-1 folder.

@github-actions

This comment has been minimized.

@Dan2Clouted Dan2Clouted added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@Dan2Clouted Dan2Clouted added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@cjyuan cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 16, 2026
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 16, 2026
@Dan2Clouted Dan2Clouted added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 18, 2026
@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2026
@Dan2Clouted
Copy link
Author

Hi CJ, Thanks for reviewing my work, hopefully everything is done now. Below are the list of changes i have made.

  1. Counted the function calls correctly (5 total: replaceAll x2, Number x2, console.log x1) and listed the lines.

  2. Rephrased the error explanation to be accurate (the original issue was a malformedreplaceAllcall / arguments not written correctly, not “missing quotes”) and stated the correct fix replaceAll(",", "").

  3. Clarified what Number(carPrice.replaceAll(",", "")) does: removes commas from the price string then converts the cleaned string into a number for calculation.

@cjyuan
Copy link
Contributor

cjyuan commented Feb 20, 2026

Changes look good and explanation is spot on. Well done.

Note: There was no "Needs Review" tag. I just assumed this PR was ready to be re-reviewed.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 20, 2026
@Dan2Clouted
Copy link
Author

Yes it was, my apologies i forgot to add the review tlabel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants