London | ITP- Jan-2026|Ping Wang|Sprint 3|1-implement-rewrite test by pathywang · Pull Request #972 · CodeYourFuture/Module-Structuring-and-Testing-Data

pathywang · 2026-02-16T20:39:25Z

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I complete code with assertEquals test then use node to run in order to make sure the code written correctly to pass test for implement part. For rewirte test, i install npm install --save-dev jest to test function with jest in different file with different cases

…xtensions Add recommended VS Code extensions

…cise-fixes Fixes and clarifications to sprint 1 exercises

The exercise claims there will be an error. Let's make there be one.

…error Re-introduce an error

This follows on from the prep.

* Remove the Debug exercise, and the time refactor exercise as they were already moved to sprint 2. * Remove the vowel refactor exercise. It's not clear what its goals are, or what it's looking for. We can re-add something here if we think it's valuable. * Make clear the implement exercises should use Jest - that's what the entire sprint was about. * Make previously "stretch" exercises be not stretch, because we've removed several pieces. * A bunch of copy edits where things were unclear or contained typos.

This is meant to round up, not round down.

Add format-time exercise

@Grajales-K

Thanks to @Grajales-K ⭐

prune repetitive or mathy assignments add scaffolding

scaffold each script file with faded examples https://cafe.cognitiveload.com.au/kb/fadedworkedexamples

reduce tasks, add naively passing tests

…5-version Revision: Overhauled coursework, general themes listed

Previously they were: 1. Very repetitive, having the trainees solve the same problem more than once which was confusing and not a great use of time. 2. Large. Reviewing the whole PR for the sprint took a long time, so was very daunting for reviewers, and led to review backlogs. 3. Hard to track who was doing the stretch, because it was maybe in the same PR or just maybe missing from the PR. Instead: 1. Re-use their implementation for both sets of tests - this emphasises also that the point of the exercise is writing tests different ways. 2. Split off the practice-tdd and stretch into their own expected separate PRs. 3. Fix up a bunch of inconsistent formatting.

LonMcGregor

This all looks good, apart from task 3 - the get card value tests. When I run npm test and run the file directly,in both cases I get tests failing telling me Error was not thrown for invalid card - is this intentional? Can you figure out why that is happening?

pathywang · 2026-02-23T21:37:19Z

thanks, it was not intentional,instead there is something wrong with my code (fn) should be fn()

github-actions · 2026-02-23T21:38:24Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/1-implement-and-rewrite-tests/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-02-23T21:38:24Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/1-implement-and-rewrite-tests/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

SallyMcGrath and others added 30 commits May 11, 2024 16:05

Initial commit

a10a524

populate with JS1 starting content

ff03570

Add recommended VS Code extensions

068aea6

Merge pull request CodeYourFuture#34 from CodeYourFuture/add-vscode-e…

7098dc1

…xtensions Add recommended VS Code extensions

Fixes and clarifications to sprint 1 exercises

c12a857

Merge pull request CodeYourFuture#36 from CodeYourFuture/sprint1-exer…

b1d18a2

…cise-fixes Fixes and clarifications to sprint 1 exercises

Re-introduce an error

073767e

The exercise claims there will be an error. Let's make there be one.

Merge pull request CodeYourFuture#37 from CodeYourFuture/reintroduce-…

4135f70

…error Re-introduce an error

Clarify and fix up typos (CodeYourFuture#40)

20723c4

Add format-time exercise

cd55275

This follows on from the prep.

Fix number rounding (CodeYourFuture#45)

9ca6f4e

This is meant to round up, not round down.

Update Sprint-2/readme.md

b1ce4e7

Merge pull request CodeYourFuture#41 from CodeYourFuture/format-time

b3e0892

Add format-time exercise

replace style guide link

0bad2d7

Thanks to @Grajales-K ⭐

disambiguate password validator requirement (CodeYourFuture#197)

1e4433f

sprint 1 - rename folders and order them

e7a2eca

update sprint 1

fa2ff46

prune repetitive or mathy assignments add scaffolding

updated sprint 2

5e88e78

scaffold each script file with faded examples https://cafe.cognitiveload.com.au/kb/fadedworkedexamples

Update Sprint 3

afd714f

reduce tasks, add naively passing tests

pics of the test explorer

c7ee463

tweak readme

f87a561

add jest as extension and suggest they install it

c933202

Merge pull request CodeYourFuture#232 from CodeYourFuture/itp-jan-202…

04c68f3

…5-version Revision: Overhauled coursework, general themes listed

Update pull_request_template.md (CodeYourFuture#450)

7ea818d

Fix the link to Style Guide in PR template

1039b76

Update repo metadata

34c4186

Set up Validate PR Metadata action

14d92e8

Update PR template

e0f3706

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 16, 2026

pathywang closed this Feb 16, 2026

pathywang reopened this Feb 21, 2026

This comment has been minimized.

Sign in to view

pathywang added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 21, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 21, 2026

added package.json back and added it to gitignore

81b57d8

pathywang added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 21, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 21, 2026

set gitignore file back to default

b19f0dd

pathywang added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 21, 2026

LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 23, 2026

LonMcGregor reviewed Feb 23, 2026

View reviewed changes

comimit

6a34eb6

pathywang added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 23, 2026

github-actions bot removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 23, 2026

pathywang closed this Feb 23, 2026

pathywang force-pushed the Sprint-3/1 branch from 1064881 to 6a34eb6 Compare February 23, 2026 22:19

pathywang deleted the Sprint-3/1 branch February 23, 2026 22:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

London | ITP- Jan-2026|Ping Wang|Sprint 3|1-implement-rewrite test#972

London | ITP- Jan-2026|Ping Wang|Sprint 3|1-implement-rewrite test#972
pathywang wants to merge 48 commits intoCodeYourFuture:mainfrom
pathywang:Sprint-3/1

pathywang commented Feb 16, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

LonMcGregor left a comment

Uh oh!

pathywang commented Feb 23, 2026

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Comments

Conversation

pathywang commented Feb 16, 2026

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

pathywang commented Feb 23, 2026

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants