Skip to content

Comments

Birmingham | ITP-Jan | Roman Sanaye | Sprint 2 | Module-Structuring-and-Testing-Data coursework#977

Closed
RomanSanaye wants to merge 11 commits intoCodeYourFuture:mainfrom
RomanSanaye:acoursework/sprint-2
Closed

Birmingham | ITP-Jan | Roman Sanaye | Sprint 2 | Module-Structuring-and-Testing-Data coursework#977
RomanSanaye wants to merge 11 commits intoCodeYourFuture:mainfrom
RomanSanaye:acoursework/sprint-2

Conversation

@RomanSanaye
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Reviewed and worked through all JS files in the following folders:

    1. 1-key-errors
    2. 2-mandatory-debug
    3. 3-mandatory-implement
    4. 4-mandatory-interpret
    5. 5-stretch-extend
  • For each folder:

    • Made predictions for outputs
    • Explained code functionality
    • Debugged and corrected errors where needed
  • In 5-stretch-extend, handled edge cases in formatAs12HourClock (midnight, noon, leading zeros) and added comprehensive tests

  • All files have been reviewed and tested, and outputs are verified

@RomanSanaye RomanSanaye added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 17, 2026
@github-actions
Copy link

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 17, 2026
@github-actions
Copy link

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@RomanSanaye RomanSanaye added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 17, 2026
@github-actions
Copy link

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant