Skip to content

PR validation: Allow giving more specific comments #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
illicitonion wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PR validation: Allow giving more specific comments #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion validate-pr-metadata/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ inputs:
GITHUB_TOKEN:
description: GitHub Token to use, probably secrets.GITHUB_TOKEN
required: true
give_more_specific_comment_for_earlier_learners:
description: |
Give more specific/directed comments, rather than more vague direction.
This should be used in the first 1-2 modules people do, to get them used to bot messages.
Avoid this once people are used to getting bot comments, because learning how to infer non-explicit instructions is a useful skill.
default: false
use_dummy_code_of_conduct_validator:
description: |
Use the dummy code of conduct validator instead of the real PR metadata validator.
Expand All @@ -25,7 +31,14 @@ runs:
USE_DUMMY_CODE_OF_CONDUCT_VALIDATOR: ${{ inputs.use_dummy_code_of_conduct_validator }}
GH_TOKEN: ${{ inputs.GITHUB_TOKEN }}
- name: Validate PR Metadata
run: /tmp/pr-metadata-validator ${{ github.event.pull_request.html_url }}
run: |
args=("/tmp/pr-metadata-validator")
if [[ "${GIVE_MORE_SPECIFIC_COMMENT_FOR_EARLIER_LEARNERS}" == "true" ]]; then
args+=("--give-more-specific-comment-for-earlier-learners")
fi
args+=("${{ github.event.pull_request.html_url }}")
exec "${args[@]}"
shell: bash
env:
GH_TOKEN: ${{ inputs.GITHUB_TOKEN }}
GIVE_MORE_SPECIFIC_COMMENT_FOR_EARLIER_LEARNERS: ${{ inputs.give_more_specific_comment_for_earlier_learners }}