Use Uni async way to do checksum validation for local downloads#84
Use Uni async way to do checksum validation for local downloads#84yma955 merged 1 commit intoCommonjava:2.0.xfrom
Conversation
| publishTrackingEvent( path, id ); | ||
| return Uni.createFrom().item( builder.build() ); | ||
| Uni<Boolean> checksumValidation = | ||
| proxyService.validateChecksum( id, packageType, type, name, path, request ); |
There was a problem hiding this comment.
Does this mean there will be an individual request for each checksum ? can we make the folo records into the archive, and verify the checksum against that, to avoid the request to indy. Just an idea, not sure if that is possible.
There was a problem hiding this comment.
Hi, @sswguo
Local checksums will read the historical unpack payload directly, so cost would be small, and for remote checksums, will only download the necessary one(s) which local also owns, once validation is done, no other checksums will be downloaded.
For the folo record you suggest, I'm not sure if it will be retrieved before build is coming to end, since this happens at the progress of one build, and report should be still sealed in progress, the folo requests here should be direct to content requests with the corresponding content path, I'm afraid it will not have a better way than this since we need to know the new latest version of content. Corrent me if I'm wrong on this if we have a way to get the whole report on the current progress build.
There was a problem hiding this comment.
@sswguo This is a way to align the version between sidecar(local downloads) and Indy content retrieving, for the archive contents alignment with the current folo record of the finished build, it had some way done from Archive service. From https://issues.redhat.com/browse/MMENG-4251 description, we could know it's not aligned, but not sure misalignment on which service, so it would be safe both would be fixed.
There was a problem hiding this comment.
@yma96 thanks for the explanation, looks good for me. ; -)
2 participants
No description provided.