Revert "Update to jakarta namespace for jpa module (#115)"#125
Merged
sswguo merged 2 commits intoCommonjava:masterfrom Oct 24, 2025
Merged
Revert "Update to jakarta namespace for jpa module (#115)"#125sswguo merged 2 commits intoCommonjava:masterfrom
sswguo merged 2 commits intoCommonjava:masterfrom
Conversation
ruhan1
approved these changes
Oct 24, 2025
Contributor
ruhan1
left a comment
ruhan1
left a comment
There was a problem hiding this comment.
LGTM, if this is the only way to make Galley happy. We can update to Jakarta later together with Galley.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 26ea824.
This moves back to using javax persistence. Using this galley is once more able to test against this. The
pathdb/jpamodule is referring to hibernate version 5 (although it mentions test scope and there are no tests). Overall path-mapped-storage refers to hibernate 5 (not 6 where they changed to jakarta https://docs.hibernate.org/orm/6.0/migration-guide/#_jakarta_persistence )