check if file responds to filename as well as to_path#2043
Open
lsylvester wants to merge 1 commit intoCompass:masterfrom
Open
check if file responds to filename as well as to_path#2043lsylvester wants to merge 1 commit intoCompass:masterfrom
lsylvester wants to merge 1 commit intoCompass:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading to rails 5 and sprockets 3.5.2,
Compass::Core::SassExtensions::Functions::ImageSize::ImagePropertiesis being initialised with aSprockets::Assetwhich no longer responds toto_path.This adds an additional check to to see the
filepassed in responds tofilenameand uses that if it is available to prevent theno implicit conversion of Sprockets::Asset into Stringerrors.Fixes #2042