Announce multiple simultaneous poll closings with one message #65
+22
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Made announcements about multiple votes closing (eg: elections, or multiple amendments) be aggregated into a single message.
Why
Currently, the slack automation will post a message for each and every vote that closes. This can result in, as a recent example, 4 votes all closing simultaneously at midnight. Users who get pinged for announcements may find this annoying, especially if it happens at midnight.
Test Plan
I do not have proper OIDC credentials, so I did not test this. Assuming the functionality worked previously, static code analysis and successful compilation indicates the code should still work.
Env Vars
N/A
Checklist