This repository was archived by the owner on Mar 11, 2024. It is now read-only.
minor typo fix and added extra security checks#3
Open
bernardpeh wants to merge 3 commits intoConsenSys-archive:masterfrom
Open
minor typo fix and added extra security checks#3bernardpeh wants to merge 3 commits intoConsenSys-archive:masterfrom
bernardpeh wants to merge 3 commits intoConsenSys-archive:masterfrom
Conversation
raid5
reviewed
Aug 18, 2017
src/js/app.js
Outdated
| var toAddress = $('#TTTransferAddress').val(); | ||
|
|
||
| console.log('Transfer ' + amount + ' TT to ' + toAddress); | ||
| console.log('Transfering ' + amount + ' TT to ' + toAddress); |
src/js/app.js
Outdated
|
|
||
| // user cannot transfer tokens to himself | ||
| if (toAddress.toLowerCase() == account.toLowerCase()) { | ||
| alert('Sorry, you cannot transfer token to yourself'); |
There was a problem hiding this comment.
I would reword these two lines to:
Sorry, you cannot transfer tokens to yourself (make token plural)
Author
|
fixed. nice tutorial. |
raid5
reviewed
Aug 18, 2017
src/js/app.js
Outdated
| if (toAddress.toLowerCase() == account.toLowerCase()) { | ||
| alert('Sorry, you cannot transfer token to yourself'); | ||
| throw new Error('cannot transfer token to yourself'); | ||
| alert('Sorry, you cannot transfer tokens nto yourself'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added .gitignore and remove references to the "pet shop" tutorial. Added a check to not transfer token to ownself.