Resolve issue of not working edit graph. #26
Resolve issue of not working edit graph. #26shivangvijay wants to merge 1 commit intoControlCore-Project:devfrom
Conversation
…n, OS checking implemented
| if [ $? == 0 ] | ||
| then | ||
| open https://controlcore-project.github.io/DHGWorkflow/ | ||
| else |
There was a problem hiding this comment.
Thanks for your attempt at fixing this issue.
A few pointers:
- When you make a fix to a bug, always make sure to do the minimal needed changes. So in this case, changing the URL was all you had to do. Other changes are irrelevant.
- I have fixed these in the recent commits.
- However, the actual reason for these bugs is due to the dev branch being stale. I am attempting to merge the main branch back into the dev. But it has some merge conflicts. So I will come back to that later. merge back to dev #28
In the meantime, please work on the main branch unless we explicitly ask you to work on the dev branch.
I close this pull request now.
There was a problem hiding this comment.
Thanks @pradeeban for your pointers. I'll consider your points.
But I working on main branch only, this issue occur in main branch as well as in dev branch. I put pull requests in dev branch because in the documentation you mentioned "Please make sure to send your concore pull requests to the dev branch."
Let me tell you the problem in detail. Please follow my screenshots that I attached in pull requests.
- "Which open" command return 0 in Linux. So, first if condition satisfy and it use "open -a 'Google Chrome' https://controlcore-project.github.io/concore-editor/
- But it will not work in Linux instead in Linux "xdg-open https://controlcore-project.github.io/concore-editor/" works.
There was a problem hiding this comment.
Hi @shivangvijay, thanks for the explanation. That makes sense.
The dev branch had become stale (because we were committing changes to the main branch and dev branch simultaneously), and any commits to that were deviating from the main. Now I have merged #28. So now you should be able to create pull requests to the dev branch, as you pointed out from the README.
We were testing on Windows and Mac and apparently did not realize the issue you pointed out. Now I have adopted your changes and committed it. Please see the updates in the relevant bug report #25.
The cause of issue#25 is in the "which open" command. As per my knowledge and research, there is no "open" command in Linux; instead, Linux uses xdg-open. But in my Linux OS, the command "which open" returns 0 as it gets some path( see attached image).
And "open -a https://controlcore-project.github.io/concore-editor/" and "open https://controlcore-project.github.io/concore-editor/" commands are not working in Linux (see attached image).
So, in my implementation, I put OS checks. I think it is a better way than the "which" command.