Align web socket client implementation between Olog and save&restore#3692
Open
georgweiss wants to merge 4 commits intomasterfrom
Open
Align web socket client implementation between Olog and save&restore#3692georgweiss wants to merge 4 commits intomasterfrom
georgweiss wants to merge 4 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to align to the same web socket client implementation for Olog and save-and-restore. Server side has also been updated to use the same Spring Boot APIs.
New modules have been created to enable use of common APIs and thus reduce code duplication.
NOTE!!!
Sadly I had to change the Olog ES client implementation such that "Olog" is prepended to all endpoints. Reason is that the Olog service by default deploys to the context "/", but all endpoints start with /Olog. At the same time the Olog client (erroneously) handled this "Olog" prefix as the context root.
ACTION NEEDED
The preference setting
org.phoebus.olog.es.api/olog_urlmust omit the "Olog" part of the URL!Checklist
Testing:
Documentation: