Open
Conversation
added 10 commits
January 12, 2023 16:51
Contributor
|
Add the label for the PR. Otherwise looks good. |
martinkilbinger
requested changes
Feb 27, 2023
Contributor
martinkilbinger
left a comment
There was a problem hiding this comment.
Please set the label of the PR.
aguinot
reviewed
Mar 8, 2023
|
|
||
| weight_map = np.copy(weights[n_e]) | ||
| weight_map[np.where(flags[n_e] != 0)] = 0. | ||
| weight_map[weight_map != 0] = 1 |
Contributor
There was a problem hiding this comment.
This will create an issue. Line 859 there is weight_map *= 1 / sig_noise ** 2 if the weight_map is not equal to 1 it will lead to weird behavior.
Author
There was a problem hiding this comment.
for theli weights, there are relative weights between pixels, which then need to be rescaled by the sky background variance to become variance maps. Thomas Erban seemed to think this operation was okay. are you talking about the weirdness associated with some megaprime weight maps that are not always 1 or 0?
martinkilbinger
approved these changes
Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewer Checklist
developbranch