Merged
Conversation
… there doesn't seem to be a failsafe way to lowercase a string in github actions)
…(which currently takes 50% of the build time)
Contributor
Author
|
@martinkilbinger please feel free to merge if you're happy with this, the shapepipe test script now gets run in the container upon commit. You can look at "Tests" here if you'd like to see this in action :) |
Contributor
Author
|
Actually, one thing I didn't do is check that my changes to the docs rendered properly.. I'm worried that the docs-building with conda is also broken, and that I'll need to move that workflow from conda to docker as well. Maybe @sfarrens can comment.. is |
martinkilbinger
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install_shapepipeand conda environment variables obsolete, but I'm not quite ready to invest the time to de-condify the docs.__installs__import inrun.pyThis could potentially close a several issues related to dependency issues on canfar/candide.
Reviewer Checklist
developbranch