Fix deadlock when crafting job with reusable ingredient depends on crafting that ingredient

[Copilot]

When a crafting job required a reusable ingredient (e.g., shears) that itself needed to be crafted as a dependency, the system would deadlock: the reusable ingredient ended up in lastMissingIngredients during buffer fill, and the update loop condition if (lastMissingIngredients.isEmpty() || true) (the || true was a temporary workaround) gated the lazy extraction that would have unblocked the job.

Changes

CraftingHelpers

• Added skipReusableIngredients flag (default false) to getIngredientRecipeInputs (new 9-param overload, 8-param delegates) and getRecipeInputs (new 8-param overload, 7-param delegates). When true, reusable ingredient slots are emitted as empty placeholders — not extracted from storage, not reported as missing.

CraftingJobHandler

• fillCraftingJobBufferFromStorage: passes skipReusableIngredients=true when the job has pending dependencies, so reusable ingredients stay in storage and are extracted lazily once dependencies complete. Removes the debug System.out.println.
• Update loop: removes the if (lastMissingIngredients.isEmpty() || true) wrapper so the reusable-ingredient handling always runs when the buffer is missing a reusable ingredient — regardless of prior fill state.

Game test

• testItemsCraftDeadBushTagReusableNeedsCrafting: reproduces the deadlock scenario — no shears in initial storage, 2 iron ingots available to craft them, requests 10 dead bushes via a reusable-shears recipe. Asserts 10 dead bushes produced and 1 shears returned.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.