Merged
Conversation
…3297) fast-xml-parser parses purely numeric AcctSvcrRef values (e.g. 20110649015) as JavaScript numbers. Passing a number to a varchar(256) column causes tedious to throw "Invalid string". Wrap both AcctSvcrRef lookups in toString() to ensure the value is always a string.
github-actions
bot
requested review from
TaprootFreak and
davidleomay
as code owners
* fix: include all custody assets in portfolio history chart The portfolio history chart was showing incorrect values (e.g. 0.01 CHF instead of 25'933 CHF) because getUserCustodyHistory() only considered assets from completed orders when fetching price history. Assets acquired through receives or other mechanisms without matching orders were missing. Additionally, order balance changes were only applied inside the price reduce loop, so volumes from order days without price records were lost. Changes: - Include assets from custody_balance table (with balance > 0) in the price query, not just assets from orders - Decouple order volume processing from price iteration by applying all cumulative order changes up to each price day before calculating value * fix: use order updated date --------- Co-authored-by: David May <david.leo.may@gmail.com>
TaprootFreak
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist