Merged
Conversation
* [NOTASK] mail texts input not allowed * [NOTASK] change text
github-actions
bot
requested review from
TaprootFreak and
davidleomay
as code owners
* fix: support ICP transaction hash lookup via Ledger API v2 Resolve external TxHashes (64 hex chars, e.g. from Binance) in isTxComplete by querying the ICP Ledger API v2. Adds configurable ICP_LEDGER_API_URL env variable with sensible default. * refactor: switch to Rosetta API and check operation status Use the standard ICP Rosetta /search/transactions endpoint instead of the Ledger API v2. Verify that all operations have status COMPLETED. Env variable renamed to ICP_ROSETTA_API_URL. Extract RosettaTransaction interface into icp.dto.ts.
davidleomay
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist