fix: switch ICP polling to DB-based RegisterStrategy#3309
Merged
davidleomay merged 3 commits intodevelopfrom Mar 3, 2026
Merged
fix: switch ICP polling to DB-based RegisterStrategy#3309davidleomay merged 3 commits intodevelopfrom
davidleomay merged 3 commits intodevelopfrom
Conversation
Replace in-memory block tracking (PollingStrategy) with DB-based block height lookups (RegisterStrategy) to prevent skipping archived blocks after API restarts. Aligns ICP with the Cardano/Citrea pattern using getActiveDepositAddresses() and per-address block filtering.
Replace global query_blocks scan with Rosetta /search/transactions per account_identifier. This avoids stalling when thousands of unrelated blocks separate the last known crypto_input from the current chain tip. Remove token PayIn code (not in use), consolidate Rosetta DTOs.
davidleomay
reviewed
Mar 3, 2026
src/subdomains/supporting/payin/strategies/register/impl/icp.strategy.ts
Show resolved
Hide resolved
davidleomay
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PollingStrategy) with DB-based block height lookups (RegisterStrategy) to prevent skipping archived blocks after API restartsgetActiveDepositAddresses(),pollAddress()and per-address block filteringEVERY_SECONDtoEVERY_MINUTE(consistent with other RegisterStrategy implementations)Test plan
npx tsc --noEmit)inTxIdformat (canisterId:blockIndex)