Merged
Conversation
…back (#3321) * fix: check Binance minimum before Lightning withdrawal to enable fallback When the Lightning withdrawal amount is below Binance's minimum (0.00002 BTC), the API rejects the request. Previously this was caught as a generic error and mapped to OrderFailedException, which immediately fails the pipeline with no fallback path. Now the minimum is checked upfront and throws OrderNotProcessableException instead, allowing the pipeline to follow the configured onFail action chain (e.g. buy liquidity via a sub-pipeline). * refactor: simplify min withdrawal check into single guard Replace two separate checks (amount <= 0 and amount < minimum) with a single check against the Binance minimum withdrawal amount. * fix: use Binance minimum withdrawal amount instead of failing When the requested amount is below Binance's Lightning minimum (0.00002 BTC), withdraw the minimum instead of rejecting the order. Only fail if the Binance balance cannot cover the minimum.
github-actions
bot
requested review from
TaprootFreak and
davidleomay
as code owners
TaprootFreak
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist