Closed
Conversation
Problem: The previous greedy matching algorithm could create suboptimal pairs, leading to unmatched transactions that should have been matched based on exact references or temporal proximity. Example case: - bank_tx 191175 (E2E-79792) created 07:31 - exchange_tx 125970 (DEPOSIT-79792) created 07:33 - These belong together (same reference, 2 min apart) - But exchange_tx 125970 was matched with bank_tx 190594 (5 days apart) - Result: 40k CHF stuck as "pending to Scrypt" for 34+ hours Solution: Implement two-phase optimal matching: Phase 1: Exact Reference Matching - Match bank_tx.endToEndId with exchange_tx.txId - Ensures transactions with matching references are paired first - Prevents false matches based purely on timing Phase 2: Optimal Timing-based Matching - Build cost matrix based on temporal proximity - Use greedy algorithm on sorted pairs (best matches first) - Ensures closest temporal matches are selected Changes: - Add matchByExactReference() method for Phase 1 - Add buildCostMatrix() and findOptimalMatches() for Phase 2 - Replace greedy iteration in filterSenderPendingList() with two-phase approach - Add comprehensive test cases for both phases - Add verbose logging for match tracking and debugging Benefits: - Prevents suboptimal matches that cause false "pending" balances - Prioritizes exact reference matches over approximations - Reduces manual intervention needed for stuck transactions - Improves overall matching accuracy and reliability
- compare-balance-logs.sh: Compare two log entries and show asset changes - sum-asset-balances.sh: Sum asset balances by financial type - inspect-asset-balance.sh: Inspect detailed balance structure for specific assets These scripts help diagnose balance calculation issues and analyze financial data logs from the /gs/debug endpoint.
TaprootFreak
force-pushed
the
chore/add-balance-debug-scripts
branch
from
aef30c7 to
f91cea5
Compare
Collaborator
Author
|
Closing - branch contained unrelated transaction matching changes. Recreating with clean branch in new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add three new debugging scripts for analyzing financial data logs:
Purpose
These scripts are diagnostic tools for investigating balance calculation issues in the financial logging system. They query the
/gs/debugendpoint and parse the complex JSON structures.Usage
All scripts require DEBUG_ADDRESS and DEBUG_SIGNATURE in
.env:Notes