[9.1] feat: added foreign keys to PilotAgentsDB#8097
Draft
fstagni wants to merge 2 commits intoDIRACGrid:integrationfrom
Draft
[9.1] feat: added foreign keys to PilotAgentsDB#8097fstagni wants to merge 2 commits intoDIRACGrid:integrationfrom
fstagni wants to merge 2 commits intoDIRACGrid:integrationfrom
Conversation
f97273f to
1ba957c
Compare
1ba957c to
808e29e
Compare
chaen
reviewed
Mar 22, 2025
| cmdList.append( | ||
| "FOREIGN KEY ( `%s` ) REFERENCES `%s` ( `%s` )" | ||
| " ON DELETE RESTRICT" % (key, forTable, forKey) | ||
| " ON DELETE CASCADE" % (key, forTable, forKey) |
Contributor
There was a problem hiding this comment.
I think this should not be the default.
Contributor
Author
There was a problem hiding this comment.
Elaborate why. It only affects TaskQueueDB and SandboxMetadataDB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For DIRACGrid/diracx#414
tq_jobsON DELETE CASCADEBEGINRELEASENOTES
*WMS
CHANGE: add foreign keys to PilotAgentsDB and SandboxMetadataDB
*Core
CHANGE: MySQL: use ON DELETE CASCADE for foreign keys by default
ENDRELEASENOTES
The issue with PilotWrapper should be fixed with DIRACGrid/Pilot#251 (still to be merged to
masterbranch...)