make compatible with pip install -e ("editable") installs + minor other fixes#58
Open
make compatible with pip install -e ("editable") installs + minor other fixes#58
pip install -e ("editable") installs + minor other fixes#58Conversation
The `setup.cfg` rearranges the output directory structure when using `pip install`. However, `pip install` has an `-e` flag, which, instead of actually installing the package, creates an "in-place" installation that's editable. The trouble is that the package structure as stored in Git (which is designed to be easier to navigate when editing) doesn't correctly interact with the path structure needed by matplotlib. Here we fix this `__init__.py` (which is not used when the package is installed via setup.py) so that it performs the same `$MPLCONFIGDIR` mangling that the `python/__init__.py` would otherwise do in a normal installation.
…ly converted to scalars)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, the
setup.cfgrearranges the output directory structure when usingpip install. However,pip installhas an-eflag, which, instead of actually installing the package, creates an "in-place" installation that's editable. The trouble is that the package structure as stored in Git (which is designed to be easier to navigate when editing) doesn't correctly interact with the path structure needed by matplotlib.Here we fix this
__init__.py(which is not used when the package is installed via setup.py) so that it performs the same$MPLCONFIGDIRmangling that thepython/__init__.pywould otherwise do in a normal installation. This PR is a solution for the problem identified in #57, but without moving all the directories around.This PR also includes a couple other smaller fixes (including a compatibility fix for one of the examples with
numpy2.4+).