Disable rim lighting (r_rimLighting) by default#1896
Open
slipher wants to merge 1 commit intoDaemonEngine:masterfrom
Open
Disable rim lighting (r_rimLighting) by default#1896slipher wants to merge 1 commit intoDaemonEngine:masterfrom
slipher wants to merge 1 commit intoDaemonEngine:masterfrom
Conversation
"Rim lighting" purports to make the edges of models stand out. However in my tests, I don't see a very strong correlation between the parts which are lit up and the edges of models. For more geometrically complex models such as the Barricade, it sometimes randomly lightens the model all over the place, which looks bad.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Rim lighting" purports to make the edges of models stand out. However in my tests, I don't see a very strong correlation between the parts which are lit up and the edges of models. For more geometrically complex models such as the Barricade, it sometimes randomly lightens the model all over the place, which seems bad.
No rim lighting:
With rim lighting:
If the idea is accepted, I will also make a PR for the graphics presets.