Fix entire db flush when no "only" keys found#15
Open
niborg wants to merge 1 commit intoDatabaseCleaner:masterfrom
Open
Fix entire db flush when no "only" keys found#15niborg wants to merge 1 commit intoDatabaseCleaner:masterfrom
niborg wants to merge 1 commit intoDatabaseCleaner:masterfrom
Conversation
Resolves bug that would wipe the entire Redis db when an `only` specification is provided but there are no matching keys in the db. This is achieved by defaulting the `only` and `except` arguments to be `nil`, which signals that they have not been set whereas implementation before was ambiguous. And if `only` has not been set, then the code knows to use all Redis keys.
|
Any reason this can't be merged? This seems like the correct way to handle |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves bug that would wipe the entire Redis db when an
onlyspecification is provided but there are no matching keys in the db. This is achieved by defaulting theonlyandexceptarguments to benil, which signals that they have not been set whereas implementation before was ambiguous. And ifonlyhas not been set, then the code knows to use all Redis keys.Closes #12