Open
Conversation
peterstangl
reviewed
Jan 31, 2026
|
|
||
| 1. Replace the CRunDec source files in the `CRunDec3/` directory with the new version, renaming them to `CRunDec.cpp` and `CRunDec.h` | ||
|
|
||
| 2. Update `setup.py` to reference the correct source files |
Contributor
There was a problem hiding this comment.
I guess after renaming the files in the previous step, this might not be necessary?
Contributor
|
When updating to 3.1, I changed several types in CRunDec.cpp to ensure compatibility with SWIG. Probably, one needs to patch version 3.1.1 again or implement my changes in the new version of RunDec |
Owner
Author
|
Oh, I see. In this PR, the .i file was modified instead. |
Owner
Author
|
Managed to fix the windows build. So tests are passing in CI now. Whether this is good enough to merge - 🤷♂️ can't say I fully understand the changes. |
|
v.3.1.2 is on the TTP webpage as well as here. |
Owner
Author
|
Great! Would be happy to retire or donate this repo eventually 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22. (?)
This is quite a mess. Although the version number suggests a patch release, signatures of functions were changed and a type was removed. My friendly AI had to add all kind of scary looking stuff to the .i file. Now tests pass...
@peterstangl @Herren FYI