Some component stuff by heypr · Pull Request #2734 · DenizenScript/Denizen

heypr · 2025-06-18T00:53:03Z

Added properties for the item_model, max_durability, food, max_stack_size, and rarity item components.
Additionally made sure that the paper ItemTag.rarity didn't conflict with the new >1.20 rarity component mech.

- Added support for the `item_model`, `max_durability`, `food`, `max_stack_size`, and `rarity` item components. - Additionally made sure that the paper `ItemTag.rarity` didn't conflict with the new >1.20 rarity component mech.

MC-Samuel · 2025-06-18T01:00:12Z

plugin/src/main/java/com/denizenscript/denizen/objects/properties/item/ItemFood.java

+    }
+
+    @Override
+    public void setPropertyValue(MapTag element, Mechanism mechanism) {


MapTag should probably use "map" instead of "element"

MC-Samuel · 2025-06-18T01:00:51Z

plugin/src/main/java/com/denizenscript/denizen/objects/properties/item/ItemMaxStackSize.java

+    }
+
+    public static void register() {
+        autoRegisterNullable("max_stack_size", ItemMaxDurability.class, ElementTag.class, false);


mcmonkey4eva · 2025-06-18T12:43:06Z

plugin/src/main/java/com/denizenscript/denizen/objects/properties/item/ItemMaxDurability.java

+    @Override
+    public ElementTag getPropertyValue() {
+        if (getItemMeta() instanceof Damageable damageable
+                && damageable.hasMaxDamage()) {


newline split is weird

mcmonkey4eva · 2025-06-18T12:44:45Z

plugin/src/main/java/com/denizenscript/denizen/objects/properties/item/ItemMaxDurability.java

+    // @name max_durability
+    // @input ElementTag
+    // @description
+    // Controls the maximum durability of an item.


The meta for things should generally have more information than this. Give examples. Give limits. Give edge cases (the tag can be null - when/why?)

mcmonkey4eva · 2025-06-18T12:45:12Z

plugin/src/main/java/com/denizenscript/denizen/objects/properties/item/ItemMaxDurability.java

+    public void setPropertyValue(ElementTag element, Mechanism mechanism) {
+        editMeta(ItemMeta.class, meta -> {
+            if (meta instanceof Damageable damageable) {
+                damageable.setMaxDamage(element.asInt());


if there's a hasMaxDamage, that implies there's a way to unset the value - how do you do that with the mech?

also before doing type conversion (asInt) you should ideally have a check/error handle

mcmonkey4eva · 2025-06-18T12:46:10Z

paper/src/main/java/com/denizenscript/denizen/paper/properties/PaperItemExtensions.java

-            return new ElementTag(item.getItemStack().getRarity());
-        });
+        if (NMSHandler.getVersion().isAtMost(NMSVersion.v1_19)) {
+            // <--[tag]


meta is double-registered, should just be excluded from a legacy copy

tal5 · 2025-07-05T22:12:42Z

plugin/src/main/java/com/denizenscript/denizen/objects/properties/item/ItemFood.java

+    public void setPropertyValue(MapTag map, Mechanism mechanism) {
+        FoodComponent food = getItemMeta().getFood();
+        editMeta(ItemMeta.class, meta -> {
+            if (map.getElement("nutrition") != null) {


The property is registered with autoRegisterNullable, which means map can be null here (and should be handled by removing the food component)

tal5 · 2025-07-05T22:12:58Z

plugin/src/main/java/com/denizenscript/denizen/objects/properties/item/ItemMaxDurability.java

+    public void setPropertyValue(ElementTag element, Mechanism mechanism) {
+        editMeta(ItemMeta.class, meta -> {


Same here, needs to handle null

davight · 2025-06-18T07:07:53Z

plugin/src/main/java/com/denizenscript/denizen/objects/properties/item/ItemFood.java

+    public void setPropertyValue(MapTag map, Mechanism mechanism) {
+        FoodComponent food = getItemMeta().getFood();
+        editMeta(ItemMeta.class, meta -> {
+            if (map.getElement("nutrition") != null) {


should probably be Map#containsKey

Or alternatively

Object value = map.get(key); if (value != null) { thing.set(value) }

davight · 2025-07-07T10:21:22Z

plugin/src/main/java/com/denizenscript/denizen/objects/properties/item/ItemFood.java

+
+    @Override
+    public void setPropertyValue(MapTag map, Mechanism mechanism) {
+        FoodComponent food = getItemMeta().getFood();


this probably could be moved in the lamba and called from the lambda parameter (meta.getFood())

tal5 · 2025-07-16T13:29:42Z

plugin/src/main/java/com/denizenscript/denizen/objects/properties/item/ItemFood.java

+    public void setPropertyValue(MapTag map, Mechanism mechanism) {
+        FoodComponent food = getItemMeta().getFood();
+        editMeta(ItemMeta.class, meta -> {
+            if (map.getElement("nutrition") != null) {


Or alternatively

Object value = map.get(key); if (value != null) { thing.set(value) }

tal5 · 2025-07-16T13:32:15Z

plugin/src/main/java/com/denizenscript/denizen/objects/properties/item/ItemMaxDurability.java

+    // @input ElementTag
+    // @description
+    // Controls the maximum durability of an item, if it can have durability.
+    // If the item cannot have durability (e.g. is not a tool or armor), this will return null.


I don't think this is necessarily the case? with item components you should be able to give any item durability (also true for other properties here, the point of item components is that you can kinda give any item any component).

Items can't be stackable and be damageable unfortunately.

tal5 · 2025-07-16T13:34:41Z

plugin/src/main/java/com/denizenscript/denizen/objects/properties/item/ItemDurability.java

-        if (attribute.startsWith("max_durability")) {
-            return new ElementTag(item.getMaterial().getMaterial().getMaxDurability())
-                    .getObjectAttribute(attribute.fulfill(1));
-        }


Is this properly backsupported? from what I can see it's completely removed from here and the new property is 1.20+

tal5 · 2025-07-16T13:37:40Z

plugin/src/main/java/com/denizenscript/denizen/objects/properties/item/ItemMaxDurability.java

+    // If the item does not have a max durability item component set, this will return the default max durability for the item type.
+    // -->


This is specific to the tag, and should be under @tag

Components :o

0e03c46

- Added support for the `item_model`, `max_durability`, `food`, `max_stack_size`, and `rarity` item components. - Additionally made sure that the paper `ItemTag.rarity` didn't conflict with the new >1.20 rarity component mech.

MC-Samuel reviewed Jun 18, 2025

View reviewed changes

Updated name + corrected registration

3b843b5

mcmonkey4eva reviewed Jun 18, 2025

View reviewed changes

Addressed comments

7041ca6

tal5 requested changes Jul 5, 2025

View reviewed changes

davight reviewed Jul 7, 2025

View reviewed changes

tal5 requested changes Jul 16, 2025

View reviewed changes

heypr added 5 commits December 4, 2025 19:16

Merge remote-tracking branch 'upstream/dev' into new-stuff

af3e6b8

Merge remote-tracking branch 'upstream/dev' into new-stuff

20a1c76

Addressed comments.

da0349d

Max durability tag for <=1.19

aeba5f6

Update ItemDurability.java

90ccdd2

		public void setPropertyValue(ElementTag element, Mechanism mechanism) {
		editMeta(ItemMeta.class, meta -> {

		// If the item does not have a max durability item component set, this will return the default max durability for the item type.
		// -->

Uh oh!

Conversation

heypr commented Jun 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants