Trial Spawner and Vaults 1.21 additions by MC-Samuel · Pull Request #2790 · DenizenScript/Denizen

MC-Samuel · 2025-11-07T04:39:33Z

Replaces #2771
Additions:

BlockDispenseLootScriptEvent
VaultChangeStateScriptEvent (Paper only)
VaultDisplayItemScriptEvent
MaterialTag.ominous for when a trial spawner or vault should be set to ominous/hard mode.
Updates:
Alphabetized a couple events in the Spigot script registry
Modernized MaterialTag.mode and added trial spawners and vaults to it

Some of this was copied from @MrMaleficus's earlier PR, so credit to them for the events.

tal5 · 2026-01-13T00:02:06Z

paper/src/main/java/com/denizenscript/denizen/paper/events/VaultChangeStateScriptEvent.java

+    //
+    // @Location true
+    //
+    // @Triggers when a vault block state changes


Needs to be block's or block changes state.
Also . at the end.

paper/src/main/java/com/denizenscript/denizen/paper/events/VaultChangesStateScriptEvent.java

tal5 · 2026-01-13T00:11:37Z

plugin/src/main/java/com/denizenscript/denizen/events/block/BlockDispenseLootScriptEvent.java

+    public BlockDispenseLootScriptEvent() {
+        registerCouldMatcher("loot dispenses from <block>");
+        this.<BlockDispenseLootScriptEvent, ListTag>registerDetermination(null, ListTag.class, (evt, context, input) -> {
+            List<ItemStack> items = new ArrayList<>();


Nitpick, but can initialize to input.size().

tal5 · 2026-01-13T00:13:31Z

plugin/src/main/java/com/denizenscript/denizen/events/block/VaultDisplayItemScriptEvent.java

+    @Override
+    public ObjectTag getContext(String name) {
+        return switch (name) {
+            case "item" -> item;


This has the same issue with the context potentially becoming outdated due to another plugin accessing it (e.g. if you - wait a bit in a script and then read it) - need to dynamically get the item here, but can keep the field for matches optimization.

tal5 · 2026-01-13T00:14:56Z

plugin/src/main/java/com/denizenscript/denizen/events/block/BlockDispenseLootScriptEvent.java

+
+    public BlockDispenseLootScriptEvent() {
+        registerCouldMatcher("loot dispenses from <block>");
+        this.<BlockDispenseLootScriptEvent, ListTag>registerDetermination(null, ListTag.class, (evt, context, input) -> {


Just in general, prefixed determinations (to match their context counterparts) are usually preferred as they're easier to understand in scripts & look cleaner if the event ever gets more than one determination.

tal5 · 2026-01-13T00:16:26Z

plugin/src/main/java/com/denizenscript/denizen/objects/properties/material/MaterialMode.java

                || data instanceof Tripwire
                || (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_19) && (data instanceof SculkCatalyst
-                                                                        || data instanceof  SculkShrieker));
+                                                                        || data instanceof  SculkShrieker))


Double space.

tal5 · 2026-01-13T00:18:47Z

plugin/src/main/java/com/denizenscript/denizen/objects/properties/material/MaterialMode.java

-        else if (isSculkCatalyst()) {
-            return ((SculkCatalyst) material.getModernData()).isBloom() ? "BLOOM" : "NORMAL"; // TODO: 1.19
+        else if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_21) && getBlockData() instanceof TrialSpawner trialSpawner) {
+            return new ElementTag(trialSpawner.getTrialSpawnerState().name(), true);


Can use the enum constructor for these

tal5 · 2026-01-26T22:15:34Z

paper/src/main/java/com/denizenscript/denizen/paper/events/VaultChangeStateScriptEvent.java

+    //
+    // @Location true
+    //
+    // @Triggers when a vault block's state changes. A list of states can be found at <@link url https://hub.spigotmc.org/javadocs/spigot/org/bukkit/block/data/type/TrialSpawner.State.html>.


vault block

TrialSpawner.State

tal5 · 2026-01-26T22:19:16Z

paper/src/main/java/com/denizenscript/denizen/paper/events/VaultChangeStateScriptEvent.java

+import org.bukkit.event.EventHandler;
+import org.bukkit.event.Listener;
+
+public class VaultChangeStateScriptEvent extends BukkitScriptEvent implements Listener {


Nitpick, but the event is called changes and this says change.

tal5 · 2026-01-26T22:25:48Z

plugin/src/main/java/com/denizenscript/denizen/events/block/VaultDisplayItemScriptEvent.java

+        if (!runInCheck(path, location)) {
+            return false;
+        }
+        if (!path.tryArgObject(2, new ItemTag(event.getDisplayItem()))) {


This could be put in a field for matches optimization (getContext should still access it directly though).

plugin/src/main/java/com/denizenscript/denizen/objects/properties/entity/EntityItem.java

tal5 · 2026-01-26T22:35:12Z

plugin/src/main/java/com/denizenscript/denizen/events/block/VaultDisplayItemScriptEvent.java

+        this.<VaultDisplayItemScriptEvent, ItemTag>registerDetermination(null, ItemTag.class, (evt, context, input) -> {
+            evt.event.setDisplayItem(input.getItemStack());
+        });


Generally prefixed determinations are preferred - easier to read/work with in code, and easier to manage for us when more get added.

tal5 · 2026-01-26T22:37:01Z

plugin/src/main/java/com/denizenscript/denizen/events/block/BlockDispenseLootScriptEvent.java

+    // @Triggers when a block dispenses loot containing multiple items.
+    //
+    // @Context
+    // <context.loot> returns a ListTag(ItemTag) of outcome items.


outcome here sounds a little weird imo? I'd just say loot items maybe, or something like items being dispensed if you want to be more explicit.

tal5 · 2026-01-26T22:38:42Z

plugin/src/main/java/com/denizenscript/denizen/events/block/BlockDispenseLootScriptEvent.java

+import java.util.ArrayList;
+import java.util.List;
+
+public class BlockDispenseLootScriptEvent extends BukkitScriptEvent implements Listener {


I believe the class name usually matches the Denizen name over the bukkit name, so that it's easier to spot in code for us.

tal5 · 2026-02-04T22:53:27Z

plugin/src/main/java/com/denizenscript/denizen/objects/properties/entity/EntityItem.java

        }
-        else if (isEnderSignal()) {
-            return new ItemTag(getEnderSignal().getItem());
+        else if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_19) && getEntity() instanceof ItemDisplay itemDisplay) { // TODO: 1.19: when 1.19 is minimum, make a 'getDisplay'


This TODO is irrelevant now

tal5 · 2026-02-04T22:59:53Z

plugin/src/main/java/com/denizenscript/denizen/objects/properties/entity/EntityItem.java

+        if (item.asType(EntityTag.class, mechanism.context).isCitizensNPC()) {
+            item.asType(EntityTag.class, mechanism.context).getDenizenNPC().getCitizen().data().setPersistent(NPC.Metadata.ITEM_ID, item.getItemStack().getType().name());
+        }


Uh, did you test this? You're referencing item because the old code had the entity under item, but in this case I'm pretty sure this would throw an NPE right away - you'd want to use object here (I.e. the property classes' entity object).

Also can just use ItemTag#getBukkitMaterial here I think

tal5 · 2026-02-04T23:03:43Z

plugin/src/main/java/com/denizenscript/denizen/events/block/BlockDispensesLootScriptEvent.java

+import java.util.ArrayList;
+import java.util.List;
+
+public class BlockDispensesLootScriptEvent extends BukkitScriptEvent implements Listener {


Event class name should match Denizen name.

MC-Samuel added 2 commits November 6, 2025 20:28

Trial spawners and vaults compatibility

1a3467e

slight fixes

2fe9140

tal5 mentioned this pull request Nov 13, 2025

Vault & Trial Spawners additions #2771

Closed

added BlockDispenseLootScriptEvent to accommodate vault loot dispensing

405bd9c

tal5 requested changes Jan 13, 2026

View reviewed changes

MC-Samuel added 3 commits January 12, 2026 16:50

minor changes

f9e83cc

meta correction

e6d417f

Merge branch 'dev' into trial-spawners-and-vaults

6d75f5d

tal5 requested changes Jan 26, 2026

View reviewed changes

MC-Samuel added 4 commits January 26, 2026 15:01

minor changes

24735b9

better item checking for context

a350d99

removed variable from determination

d656153

clarified OminousItemSpawner

4fc35e7

tal5 requested changes Feb 4, 2026

View reviewed changes

minor changes

50b36f8

Uh oh!

Conversation

MC-Samuel commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tal5 Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MC-Samuel commented Nov 7, 2025 •

edited

Loading

tal5 Jan 26, 2026 •

edited

Loading