Conversation
📝 WalkthroughWalkthroughThe pull request introduces a new optional workflow input Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
README.md (1)
62-62: Clarifyextra-nix-confformatting expectations.Since this value is injected verbatim into the Nix
extra-confblock, callers will likely need to pass a multiline|string innix.confsyntax. A short clarification here will prevent misuse.✍️ Suggested doc tweak
-| `extra-nix-conf` | Extra Nix configuration to pass to Determinate Nix | | +| `extra-nix-conf` | Extra Nix configuration (nix.conf syntax; multiline supported) to pass to Determinate Nix | |🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` at line 62, The README entry for the configuration key extra-nix-conf is unclear about expected formatting; update the description for extra-nix-conf to state that its value is injected verbatim into Nix's extra-conf block and therefore should be provided as a multiline string using Nix/nix.conf syntax (for example a pipe-prefixed | heredoc or equivalent multiline string) so callers know to pass newline-separated configuration lines rather than a single-line comma/space-delimited value; mention that it must contain valid nix.conf entries and preserve newlines.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/workflow.yml:
- Around line 133-135: The Determinate Nix invocations only include the
extra-conf block in the build job; mirror that same extra-conf block (containing
"extra-experimental-features = provenance" and "${{ inputs.extra-nix-conf }}")
on the other Determinate Nix action steps so inventory and success/publish runs
receive the same settings—update the Determinate Nix steps in the inventory job
and the success/publish job to include the identical extra-conf block used in
the build job.
---
Nitpick comments:
In `@README.md`:
- Line 62: The README entry for the configuration key extra-nix-conf is unclear
about expected formatting; update the description for extra-nix-conf to state
that its value is injected verbatim into Nix's extra-conf block and therefore
should be provided as a multiline string using Nix/nix.conf syntax (for example
a pipe-prefixed | heredoc or equivalent multiline string) so callers know to
pass newline-separated configuration lines rather than a single-line
comma/space-delimited value; mention that it must contain valid nix.conf entries
and preserve newlines.
| extra-conf: | | ||
| extra-experimental-features = provenance | ||
| ${{ inputs.extra-nix-conf }} |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Show all Determinate Nix action usages and their surrounding context.
rg -n -C3 'DeterminateSystems/determinate-nix-action@v3' .github/workflows/workflow.ymlRepository: DeterminateSystems/ci
Length of output: 1449
Propagate extra-nix-conf to all Determinate Nix steps.
The extra-conf block with extra-experimental-features = provenance and ${{ inputs.extra-nix-conf }} is only applied in the build job (lines 131-135). The inventory job (line 103) and success/publish job (line 171) also run Determinate Nix without this config, which can break workflows that rely on extra Nix settings before build or during publish. Apply the same extra-conf block to all Determinate Nix action invocations.
Suggested fix (apply extra-conf consistently)
@@
- - uses: DeterminateSystems/determinate-nix-action@v3
+ - uses: DeterminateSystems/determinate-nix-action@v3
+ with:
+ extra-conf: |
+ extra-experimental-features = provenance
+ ${{ inputs.extra-nix-conf }}
@@
- - uses: DeterminateSystems/determinate-nix-action@v3
+ - uses: DeterminateSystems/determinate-nix-action@v3
if: ${{ !github.repository.fork && inputs.visibility != '' && (github.ref == format('refs/heads/{0}', inputs.default-branch) || startsWith(github.ref, 'refs/tags/')) }}
+ with:
+ extra-conf: |
+ extra-experimental-features = provenance
+ ${{ inputs.extra-nix-conf }}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/workflow.yml around lines 133 - 135, The Determinate Nix
invocations only include the extra-conf block in the build job; mirror that same
extra-conf block (containing "extra-experimental-features = provenance" and "${{
inputs.extra-nix-conf }}") on the other Determinate Nix action steps so
inventory and success/publish runs receive the same settings—update the
Determinate Nix steps in the inventory job and the success/publish job to
include the identical extra-conf block used in the build job.
2 participants
Makes it easy to configure anything extra
Summary by CodeRabbit
New Features
extra-nix-confworkflow input to allow passing additional Nix configuration during builds.Documentation
extra-nix-confconfiguration option.