[#168] Timetable Page v2에 Add Course Button 추가#237
Open
halionaz wants to merge 1 commit into#168/refactor-timetablefrom
Open
[#168] Timetable Page v2에 Add Course Button 추가#237halionaz wants to merge 1 commit into#168/refactor-timetablefrom
halionaz wants to merge 1 commit into#168/refactor-timetablefrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the timetable page to allow course addition via query-string-based semester and index, while also aligning the design with the updated course page styling.
- Updated CSS styles for headers, course names, and footers to include new layout properties (e.g., gap, text overflow, flex adjustments).
- Modified the SearchLectureCard component to integrate a new course addition hook and pass timetableId rather than relying on the legacy addCourse prop.
- Updated SearchResult to pass timetableId when rendering cards.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/domain/Timetable/components/LectureBottomSheet/AddClass/SerchLectureCard/style.css.ts | Enhanced styling for header, course name formatting, and added button styles. |
| src/domain/Timetable/components/LectureBottomSheet/AddClass/SerchLectureCard/index.tsx | Refactored SearchLectureCard to include timetableId and use a new hook for adding courses, though an outdated prop remains unused. |
| src/domain/Timetable/components/LectureBottomSheet/AddClass/SearchResult/index.tsx | Updated component usage to forward timetableId correctly. |
Comments suppressed due to low confidence (2)
src/domain/Timetable/components/LectureBottomSheet/AddClass/SerchLectureCard/index.tsx:10
- The addCourse prop is still defined in SearchLectureCardProps but is no longer used in the component as the new usePostCourse hook is taking over. Consider removing this unused prop to clean up the component interface.
interface SearchLectureCardProps {
src/domain/Timetable/components/LectureBottomSheet/AddClass/SerchLectureCard/index.tsx:1
- The file path and name 'SerchLectureCard' appear to contain a typo. Consider renaming the file to 'SearchLectureCard' to match the component name and improve clarity.
// Module declarations...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 내용
☑️ 체크 사항
❗ Related Issues