Skip to content

LIMS-2037: Remove manual check for duplicate acronyms#1034

Open
ndg63276 wants to merge 2 commits intomasterfrom
improvement/LIMS-2037/remove-manual-check-for-unique-acronym
Open

LIMS-2037: Remove manual check for duplicate acronyms#1034
ndg63276 wants to merge 2 commits intomasterfrom
improvement/LIMS-2037/remove-manual-check-for-unique-acronym

Conversation

@ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-2037

Summary:

Previously csv-file-validator wouldn't identify which rows had duplicate acronyms, so we had to manually check ourselves. Version 1.10.2 onwards has this functionality built in.

Changes:

  • Ensure csv-file-validator is at least 1.10.2 (we have been using 1.13.1 for years)
  • Remove manual check for duplicate acronyms, and variables used in that
  • Add unique constraint to acronym column, with suitable error message
  • Slightly simplify the check for extra commas and reforming the csv data blob

To test:

  • Go to an I15-1 proposal, eg cm37261
  • Go to Phases from the main menu, then click on a Phase
  • Click "Add new simple sample"
  • Choose "File upload for multiple samples"
  • Select this file duplicate_acronym.csv
  • Check an error appears about a duplicate acronym on row 3
  • Edit the file to have a unique acronym, refresh the page and re-select the file, check no errors occur, click "Add Sample" and check it uploads as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments