LIMS-2054: Dont exclude peaks from MCA spectra#1036
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-2054
Summary:
The SynchWeb view of MCA spectra uses logic to determine whether to label fitted peaks by comparing the energy of emission lines to a cutoff applied to exclude the Compton scattering region of the spectrum (currently applied as a blanket beam energy - 1 keV cutoff).
This logic is redundant as similar logic is applied at the analysis step and peaks would not be included in the results file if they fall into this cutoff region. The code should therefore be removed to avoid needing to change logic in two locations if the application of the cutoff needs to be modified.
Changes:
To test:
NB
There is also code to plot the graph within 1100eV as a different colour, just above this change. That is to be addressed in ticket LIMS-2055