Skip to content

LIMS-2054: Dont exclude peaks from MCA spectra#1036

Open
ndg63276 wants to merge 1 commit intomasterfrom
fix/LIMS-2054/dont-exclude-peaks-from-mca-spectra
Open

LIMS-2054: Dont exclude peaks from MCA spectra#1036
ndg63276 wants to merge 1 commit intomasterfrom
fix/LIMS-2054/dont-exclude-peaks-from-mca-spectra

Conversation

@ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Feb 17, 2026

JIRA ticket: LIMS-2054

Summary:

The SynchWeb view of MCA spectra uses logic to determine whether to label fitted peaks by comparing the energy of emission lines to a cutoff applied to exclude the Compton scattering region of the spectrum (currently applied as a blanket beam energy - 1 keV cutoff).

This logic is redundant as similar logic is applied at the analysis step and peaks would not be included in the results file if they fall into this cutoff region. The code should therefore be removed to avoid needing to change logic in two locations if the application of the cutoff needs to be modified.

Changes:

  • Don't exclude peaks within 1keV of the beam energy

To test:

  • Go to /dc/visit/lb42888-63/ty/mca/id/18384, check there are 2 labelled Zn peaks

NB
There is also code to plot the graph within 1100eV as a different colour, just above this change. That is to be addressed in ticket LIMS-2055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments