fix: Check if plan parameter is subclass of Device #1368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1368 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 43 43
Lines 2782 2782
=======================================
Hits 2644 2644
Misses 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The previous check for whether a parameter was a bluesky device (and would therefore go via the string-to-device lookup) was based on the type being an instance of one of the bluesky protocols. For a device that only extends `Device`, this check would return False and the device could not be injected. Including a check for the type being a subclass of Device allows all device subclasses to be looked up.
get_origin returns 'Any | None' so we should accept the same
tpoliaw
force-pushed
the
device-lookup
branch
from
09d722b to
dfdfdc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous check for whether a parameter was a bluesky device (and
would therefore go via the string-to-device lookup) was based on the
type being an instance of one of the bluesky protocols.
For a device that only extends
Device, this check would return Falseand the device could not be injected.
Including a check for the type being a subclass of Device allows all
device subclasses to be looked up.