Made changes to match prefixes with wildcards#147
Open
adedamola-sode wants to merge 3 commits intomainfrom
Open
Made changes to match prefixes with wildcards#147adedamola-sode wants to merge 3 commits intomainfrom
adedamola-sode wants to merge 3 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
- Coverage 81.89% 81.18% -0.72%
==========================================
Files 7 7
Lines 580 590 +10
==========================================
+ Hits 475 479 +4
- Misses 105 111 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
niamhdougan
requested changes
Oct 24, 2025
Collaborator
|
Have tested this again and seems to be working/reporting sensible logs. |
niamhdougan
approved these changes
Oct 27, 2025
niamhdougan
requested changes
Oct 27, 2025
Collaborator
niamhdougan
left a comment
There was a problem hiding this comment.
Re-opening so we can account for more use cases like
prefix: *DCM*
or
prefix: MY-PREFIX:[X, Y, Z]
Collaborator
Author
|
Should work with those now |
OCopping
reviewed
Oct 30, 2025
e0bbec8 to
b3d61ab
Compare
Collaborator
|
I rebased this on main and fixed the merge conflict |
b3d61ab to
52ca422
Compare
52ca422 to
107ed38
Compare
107ed38 to
8e78e11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the ability for users to add wildcards in the prefixes, needs extensive testing