[WIP] issueasset contract_hash arg, default of generated key in wallet#560
Open
instagibbs wants to merge 1 commit intoElementsProject:masterfrom
Open
[WIP] issueasset contract_hash arg, default of generated key in wallet#560instagibbs wants to merge 1 commit intoElementsProject:masterfrom
instagibbs wants to merge 1 commit intoElementsProject:masterfrom
Conversation
instagibbs
changed the title
Contributor
Author
|
After further discussion, I think the best way to go forward is to have the wallet actually have proper records to look up the public key for the issuance, rather than some janky API that involves hard-to-find keys. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completely untested, needs tests and maybe more RPC helpers.
Kind of annoying it's the sha2 of the public key, but I gotta figure out how to graft a hash160 into it instead as the alternative.
resolves #536