gRPC: lightningd: Fix empty description field in listpays & listsendpays#8803
Open
erdoganishe wants to merge 3 commits intoElementsProject:masterfrom
Open
gRPC: lightningd: Fix empty description field in listpays & listsendpays#8803erdoganishe wants to merge 3 commits intoElementsProject:masterfrom
erdoganishe wants to merge 3 commits intoElementsProject:masterfrom
Conversation
b3ff08b to
c40f304
Compare
c40f304 to
ea6f718
Compare
ea6f718 to
b232f37
Compare
cdecker
approved these changes
Jan 6, 2026
Member
cdecker
left a comment
There was a problem hiding this comment.
Excellent find, and great job generating all the dependent files.
ACK
b232f37 to
3a8c6a9
Compare
Contributor
|
No. The "description" field here is: It's usually missing. This is not the description field of the bolt11 / bolt12. |
b949921 to
824f467
Compare
efc34f2 to
a5dc0cd
Compare
Changelog-Added: Fix empty `description` field for gRPC `listpays` and `listsendpays`. No schema change required; the field already existed but was not populated.
Changelog-Added: Fix empty `description` field for gRPC `listpays` and `listsendpays`. No schema change required; the field already existed but was not populated.
a5dc0cd to
36d0497
Compare
36d0497 to
d5161e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7973.
This PR fixes the description field being returned as empty in gRPC responses for listpays and listsendpays.
The field already existed, but was not being populated correctly in these gRPC paths.
After this change, the description is correctly propagated and returned for completed payments.
Examples:
No schema change is required: the description field already existed in both the database and RPC definitions.
The fix ensures the field is correctly populated and forwarded in gRPC responses.
Existing SQL tests pass without modification, since description is an additional optional field and does not affect existing column expectations.