Skip to content

cln-grpc: add missing notifications #8874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daywalker90 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

cln-grpc: add missing notifications #8874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
21bda95
msggen: propagate root added and deprecated fields
daywalker90 Jan 31, 2026
44a73d4
schemas: fix added fields metadata
daywalker90 Jan 31, 2026
33af461
msggen: raise oldest supported version to v24.11
daywalker90 Jan 31, 2026
d33109b
schemas: add all missing documented notifications
daywalker90 Jan 31, 2026
dade5c9
crates: add CLOSED to ChannelState for channel_state_changed notifici…
daywalker90 Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,257 changes: 1,060 additions & 197 deletions .msggen.json
View file
Open in desktop

Large diffs are not rendered by default.

377 changes: 342 additions & 35 deletions cln-grpc/proto/node.proto
View file
Open in desktop

Large diffs are not rendered by default.

677 changes: 632 additions & 45 deletions cln-grpc/src/convert.rs
View file
Open in desktop

Large diffs are not rendered by default.

425 changes: 425 additions & 0 deletions cln-grpc/src/server.rs
View file
Open in desktop

Large diffs are not rendered by default.

247 changes: 105 additions & 142 deletions cln-rpc/src/model.rs
View file
Open in desktop

Large diffs are not rendered by default.

605 changes: 605 additions & 0 deletions cln-rpc/src/notifications.rs
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 4 additions & 1 deletion cln-rpc/src/primitives.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ pub enum ChannelState {
CHANNELD_AWAITING_SPLICE = 11,
DUALOPEND_OPEN_COMMITTED = 12,
DUALOPEND_OPEN_COMMIT_READY = 13,
CLOSED = 14,
}

/// ['The first 10 states are for `out`, the next 10 are for `in`.']
Expand Down Expand Up @@ -461,6 +462,7 @@ impl TryFrom<i32> for ChannelState {
11 => Ok(ChannelState::CHANNELD_AWAITING_SPLICE),
12 => Ok(ChannelState::DUALOPEND_OPEN_COMMITTED),
13 => Ok(ChannelState::DUALOPEND_OPEN_COMMIT_READY),
14 => Ok(ChannelState::CLOSED),
_ => Err(anyhow!("Invalid channel state {}", value)),
}
}
Expand All @@ -483,6 +485,7 @@ impl Display for ChannelState {
ChannelState::CHANNELD_AWAITING_SPLICE => write!(f, "CHANNELD_AWAITING_SPLICE"),
ChannelState::DUALOPEND_OPEN_COMMITTED => write!(f, "DUALOPEND_OPEN_COMMITTED"),
ChannelState::DUALOPEND_OPEN_COMMIT_READY => write!(f, "DUALOPEND_OPEN_COMMIT_READY"),
ChannelState::CLOSED => write!(f, "CLOSED"),
}
}
}
Expand Down Expand Up @@ -928,7 +931,7 @@ mod test {
});

let p: FundchannelResponse = serde_json::from_value(r).unwrap();
assert_eq!(p.channel_type.unwrap().bits, vec![1, 3, 5]);
assert_eq!(p.channel_type.bits, vec![1, 3, 5]);
}
}

Expand Down
2 changes: 1 addition & 1 deletion contrib/msggen/msggen/patch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def supported():
fields more stringent.
"""

return OptionalPatch.version_to_number("v0.10.1")
return OptionalPatch.version_to_number("v24.11")

def visit(self, f: model.Field, parent: Optional[model.Field] = None) -> None:
# Return if the optional field has been set already
Expand Down
Loading
Loading