cln-grpc: add missing notifications#8874
Open
daywalker90 wants to merge 5 commits intoElementsProject:masterfrom
Open
cln-grpc: add missing notifications#8874daywalker90 wants to merge 5 commits intoElementsProject:masterfrom
daywalker90 wants to merge 5 commits intoElementsProject:masterfrom
Conversation
daywalker90
force-pushed
the
cln-grp-missing-notifications
branch
from
74287f0 to
57d134d
Compare
daywalker90
force-pushed
the
cln-grp-missing-notifications
branch
from
57d134d to
74009c9
Compare
Changelog-None
daywalker90
force-pushed
the
cln-grp-missing-notifications
branch
from
74009c9 to
d33109b
Compare
Collaborator
Author
|
I also fixed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #8873
While working on the AlbyHub CLN backend i noticed that cln-grpc was missing some important notifications like
invoice_payment. So i want to add them all. Atleast the ones documented here: https://docs.corelightning.org/docs/event-notificationsWhile testing these i noticed that there are even more notifications in CLN that are not documented on that website and because i now use the wildcard subscription cause the occasional log entry about failed notification parses.
Should i:
channel_hint_updateandpay_successbut there are more)@ErikDeSmedt What problems did you notice when using the wildcard subscription? For me it's working fine.