Merged
Conversation
Member
|
Please remove e8cff54 from this PR. |
Member
This would be a hardforking change. See ElementsProject/ELIPs#31 for a first step toward correcting it. |
4e3fc6b to
33d4b17
Compare
Contributor
Author
|
Removed the commit. Oh, great to see an ELIP regarding this topic. Will check it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed
MAX_MONEYrestriction as it is only useful for Bitcoin. As discussed with Andrew,rest-elementsshould be chain-agnostic, so no need for this check to exist.I believe this restriction may also be relaxed in the
elementsrepository for alternative assets. By doing so, it would allow more useful information to be stored on-chain (up to 12 more bits per UTXO!).