add stage 2 compatibility for FabricLoader subclasses e.g. lunar client#28
Open
add stage 2 compatibility for FabricLoader subclasses e.g. lunar client#28
Conversation
Johni0702
reviewed
Jan 5, 2026
stage2/fabric/src/main/java/gg/essential/loader/stage2/EssentialLoader.java
Show resolved
Hide resolved
Linear: EM-3472
Author
|
confirmed to have fixed this lunar client load exception note essential still doesn't appear in the mod menu on lunar client, but it is loaded and accessibla via the vanilla settings screen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am unable to test via local maven due to build failures on windows due to it generating directories with ":"
If there is some other testing method @Johni0702 i'd like to learn it / give it a go before we merge, also just to make sure there isnt anything else affecting this linear issue that the reporter may have missed.
Linear: EM-3472