Feature/sof 5462 - get name from file content#54
Open
adewyer wants to merge 7 commits intoepic/SOF-5386from
Open
Feature/sof 5462 - get name from file content#54adewyer wants to merge 7 commits intoepic/SOF-5386from
adewyer wants to merge 7 commits intoepic/SOF-5386from
Conversation
adewyer
force-pushed
the
feature/SOF-5462
branch
from
2000713 to
b42852d
Compare
src/parsers/xyz.js
Outdated
| if (name === materialNameFromFile || !materialNameFromFile) { | ||
| return name; | ||
| } | ||
| return materialNameFromFile; |
Member
There was a problem hiding this comment.
- Add a general utility -
getLineFromContent(lineNumber) materialNameFromFileContents->getNameFromContentsgetNameFromContents(fileContent) => {return getLineFromContent(1)}for POSCAR, and0for XYZ
The default name and everything on lines 152-154 should not be dealt with here. We could add a function named:getNameFromFIleContent(type, fileContent, failoverName = "material")and use as a proxy.
…turning number of atoms line to trim whitespace.
timurbazhirov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.