refactor(demo): use separate stylesheet for StyledBadgesDemo#29
refactor(demo): use separate stylesheet for StyledBadgesDemo#29javier-godoy merged 1 commit intomasterfrom
Conversation
WalkthroughAdds a class-level Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/test/java/com/flowingcode/vaadin/addons/badgelist/StyledBadgesDemo.java (1)
22-42: Fix incorrect CSS file path in conditional@DemoSourceannotation.The actual CSS file is located at
src/test/resources/META-INF/frontend/styles/styled-badges-demo.css, but the@DemoSourceannotation (lines 36–37) references/src/test/resources/META-INF/resources/frontend/styles/styled-badges-demo.csswith an extraresources/directory level. This path mismatch will break the demo "view source" feature. Update the path to/src/test/resources/META-INF/frontend/styles/styled-badges-demo.css.Fix
@DemoSource(value = "/src/test/resources/META-INF/resources/frontend/styles/styled-badges-demo.css", caption = "styled-badges-demo.css") +// should be: +// @DemoSource(value = "/src/test/resources/META-INF/frontend/styles/styled-badges-demo.css", +// caption = "styled-badges-demo.css")
🤖 Fix all issues with AI agents
In @src/test/resources/META-INF/frontend/styles/styled-badges-demo.css:
- Around line 21-26: The selector uses a brittle attribute-equals match
(fc-badge-list[class="styled-badges-second-example"]) — replace it with a class
selector to be robust: target
fc-badge-list.styled-badges-second-example::part(overflow-badge) instead,
keeping the existing .custom-styled-badge rule and preserving the
background-color, color, border and border-radius declarations; update the
selector in the rule that currently contains
fc-badge-list[class="styled-badges-second-example"]::part(overflow-badge) so it
uses the class-based selector.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/test/java/com/flowingcode/vaadin/addons/badgelist/StyledBadgesDemo.javasrc/test/resources/META-INF/frontend/styles/badge-list-demo-styles.csssrc/test/resources/META-INF/frontend/styles/styled-badges-demo.css
🔇 Additional comments (1)
src/test/resources/META-INF/frontend/styles/badge-list-demo-styles.css (1)
5-5: License header year update looks good.
src/test/resources/META-INF/frontend/styles/styled-badges-demo.css
Outdated
Show resolved
Hide resolved
8700f58 to
3ce6b72
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @src/test/java/com/flowingcode/vaadin/addons/badgelist/StyledBadgesDemo.java:
- Around line 35-38: Update the DemoSource annotation in StyledBadgesDemo (the
DemoSource on the class) to use the correct resource path by removing the extra
"/resources" segment; change the value from
"/src/test/resources/META-INF/resources/frontend/styles/styled-badges-demo.css"
to "src/test/resources/META-INF/frontend/styles/styled-badges-demo.css" so it
points to the actual file location (the CssImport can remain as-is).
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/test/java/com/flowingcode/vaadin/addons/badgelist/StyledBadgesDemo.javasrc/test/resources/META-INF/frontend/styles/badge-list-demo-styles.csssrc/test/resources/META-INF/frontend/styles/styled-badges-demo.css
🚧 Files skipped from review as they are similar to previous changes (2)
- src/test/resources/META-INF/frontend/styles/styled-badges-demo.css
- src/test/resources/META-INF/frontend/styles/badge-list-demo-styles.css
🔇 Additional comments (2)
src/test/java/com/flowingcode/vaadin/addons/badgelist/StyledBadgesDemo.java (2)
5-5: LGTM!Copyright year update is appropriate for 2026.
24-24: LGTM!The import for
CssImportis correctly added to support the annotation on line 41.
src/test/java/com/flowingcode/vaadin/addons/badgelist/StyledBadgesDemo.java
Outdated
Show resolved
Hide resolved
3ce6b72 to
81a034d
Compare
|



Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.