Skip to content

Conversation

@paodb
Copy link
Member

@paodb paodb commented Feb 9, 2026

This PR addresses necessary updates so the component is compatible with Vaadin 25.

This includes:

  • add dependency gwt-elemental
  • avoid use of commons.lang3
  • add AppShellConfiguratorImpl
  • update version to 2.1.0-SNAPSHOT

Summary by CodeRabbit

  • Chores
    • Updated project version to 2.1.0-SNAPSHOT
    • Upgraded Vaadin framework support to version 25.0.3
    • Added gwt-elemental dependency
    • Refactored internal dependencies for improved maintainability
    • Updated copyright years across project files

@coderabbitai
Copy link

coderabbitai bot commented Feb 9, 2026

Walkthrough

The PR updates the project version to 2.1.0-SNAPSHOT, adds GWT-elemental dependency, upgrades Vaadin from 25.0.0 to 25.0.3, introduces a new OptionsUtils utility class for string blank checks, refactors existing code to use the new utility instead of Apache Commons StringUtils, adds a test AppShellConfiguratorImpl class, and updates copyright years across all files to 2026.

Changes

Cohort / File(s) Summary
Build Configuration
pom.xml
Project version bumped to 2.1.0-SNAPSHOT; Vaadin updated to 25.0.3; GWT-elemental 2.8.2.vaadin2 dependency added; AppShellConfiguratorImpl exclusion added to demo-jar packaging.
String Utility Refactoring
src/main/java/com/flowingcode/vaadin/addons/shareeasy/util/CustomDriverOptions.java, src/main/java/com/flowingcode/vaadin/addons/shareeasy/util/Options.java
Replaced org.apache.commons.lang3.StringUtils.isNotBlank() calls with new OptionsUtils.isNotBlank() method; removed StringUtils import dependency.
New Utility Class
src/main/java/com/flowingcode/vaadin/addons/shareeasy/util/OptionsUtils.java
Added new package-private utility class with static isNotBlank(String) method for blank string validation.
Test Infrastructure
src/test/java/com/flowingcode/vaadin/addons/AppShellConfiguratorImpl.java
New test class implementing Vaadin's AppShellConfigurator with @Theme annotation; serves as default shell configurator for testing.
Source Code Copyright Updates
src/main/java/com/flowingcode/vaadin/addons/shareeasy/*.java, src/main/java/com/flowingcode/vaadin/addons/shareeasy/enums/*.java, src/main/java/com/flowingcode/vaadin/addons/shareeasy/util/LanguageKeys.java
Copyright year header updated from 2025 to 2026 (or 2023-2025 to 2023-2026 where applicable); no functional changes.
Test Code Copyright Updates
src/test/java/com/flowingcode/vaadin/addons/DemoLayout.java, src/test/java/com/flowingcode/vaadin/addons/shareeasy/*.java, src/test/java/com/flowingcode/vaadin/addons/shareeasy/it/*.java, src/test/java/com/flowingcode/vaadin/addons/shareeasy/test/SerializationTest.java
Copyright year header updated to 2026 across all test classes; no functional changes.
Resource Files
src/main/resources/META-INF/VAADIN/package.properties, src/main/resources/META-INF/resources/frontend/src/fc-sharee-connector.js, src/test/resources/META-INF/frontend/styles/share-easy-demo-styles.css
Copyright year header updated to 2026 in properties file, JavaScript connector, and CSS styles; no functional changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

  • javier-godoy
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main objective of the pull request - adding Vaadin 25 compatibility. It directly reflects the primary intent and is clear and specific.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch issue-21

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
src/test/java/com/flowingcode/vaadin/addons/shareeasy/TrelloDriverOptions.java (1)

32-32: Nit: extra semicolon.

Pre-existing, but there's a stray double semicolon on this line (; ;).

Suggested fix
-    this.setButtonText("Trello"); ;
+    this.setButtonText("Trello");
src/test/java/com/flowingcode/vaadin/addons/AppShellConfiguratorImpl.java (1)

25-28: New AppShellConfigurator implementation for Vaadin 25 demo support looks correct.

Minor nit: Other classes in this project use @SuppressWarnings("serial"). Since AppShellConfigurator extends Serializable, you may want to add it here for consistency, or declare a serialVersionUID.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@paodb paodb requested a review from javier-godoy February 9, 2026 19:56
@paodb paodb marked this pull request as ready for review February 9, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant