BUGFIX: Propagate index postfix to NodeIndexerInterface instance#425
Open
paavo wants to merge 1 commit intoFlowpack:8.0from
Open
BUGFIX: Propagate index postfix to NodeIndexerInterface instance#425paavo wants to merge 1 commit intoFlowpack:8.0from
paavo wants to merge 1 commit intoFlowpack:8.0from
Conversation
When ContentRepositoryQueueIndexer is installed, NodeIndexerInterface resolves to a different singleton than the concrete NodeIndexer class. configureNodeIndexer() only set the postfix on the concrete instance, so the QueueIndexer instance used by NodeIndexingManager had no postfix. This caused nodeindex:build to index into the alias (old index) instead of the new postfixed index. Resolves: Flowpack#424
Contributor
Author
|
Companion PR for QueueIndexer: Flowpack/Flowpack.ElasticSearch.ContentRepositoryQueueIndexer#61 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When ContentRepositoryQueueIndexer is installed, nodeindex:build indexes into the old index instead of the new one.
NodeIndexCommandController injects the concrete NodeIndexer class, while NodeIndexingManager injects NodeIndexerInterface (which resolves to the QueueIndexer subclass). These are two separate singleton instances. configureNodeIndexer() only sets the postfix on the concrete instance, so the QueueIndexer instance has no postfix and getIndexName() returns the alias name, routing documents to the old index.
Fix
Additionally inject NodeIndexerInterface and propagate postfix/dimensions to both instances in configureNodeIndexer().
Resolves #424